Conversation
skyrpex
requested changes
Sep 8, 2025
Collaborator
skyrpex
left a comment
skyrpex
left a comment
There was a problem hiding this comment.
Nice job! Just some nits as always :)
If we start pulling docker image as a first thing in the setup process then `docker pull` consumes all the bandwidth and makes CLI download an order of magnitude longer. If we start pulling image right after the install step it still takes advantage of time that user spends in the rest of setup steps. Options considered: start `docker pull` right after CLI is downloaded. This way we could take advantage of time spent in another modal - global/local selection. Trade off is that passing image pull progress from/to runInstallProcess is adding complexity that is not justified with 2-3 seconds saved.
inspectDockerImage was returning only a limited version data. If we need a generic inspect function later then we could extract it, right now there is no need as there is no other usage of inspect.
tiurin
force-pushed
the
prefetch-docker-image
branch
from
872188a to
878347d
Compare
anisaoshafi
reviewed
Sep 8, 2025
src/utils/setup.ts
Outdated
| }; | ||
| } | ||
|
|
||
| const LOCALSTACK_DOCKER_IMAGE = "localstack/localstack-pro"; |
Collaborator
There was a problem hiding this comment.
Maybe we can import this constant from utils/cli.ts as it's defined there too?
Collaborator
Author
There was a problem hiding this comment.
Great point, let's make sure we download what we are going to use! 😄 Moved to global constants module.
anisaoshafi
approved these changes
Sep 8, 2025
Collaborator
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Nice improvement, good job 🚀
joe4dev
reviewed
Sep 9, 2025
|
|
||
| if (!imagePulled) { | ||
| progress.report({ | ||
| message: "Downloading LocalStack docker image...", |
Member
There was a problem hiding this comment.
nit capitalization: @tiurin "Docker" as a name is preferably capitalized
Collaborator
Author
There was a problem hiding this comment.
thanks, will fix it in one of the upcoming releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds start pulling docker image if doesn't exist after CLI install. This saves user time as image is pulled anyway and first LocalStack run.
Reasoning:
If we start pulling docker image as a first thing in the setup process then
docker pullconsumes all the bandwidth and makes CLI download an order of magnitude longer.But if we start pulling image right after the install step it still takes advantage of time that user spends in the rest of setup steps.
Options considered: start
docker pullright after CLI is downloaded. This way we could take advantage of time spent in another modal - global/local selection. Trade off is that passing image pull progress from/to runInstallProcess is adding complexity that is not justified with 2-3 seconds saved.